core: Add ruff rules TC #29268
Merged
core: Add ruff rules TC #29268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
cbornet
force-pushed
the
ruff-core-tch
branch
from
aa1bd97 to
a46a24b
Compare
cbornet
force-pushed
the
ruff-core-tch
branch
from
a46a24b to
f175319
Compare
dosubot
bot
added
size:XS
dosubot
bot
added
size:L
cbornet
force-pushed
the
ruff-core-tch
branch
4 times, most recently
from
3da570b to
91555d0
Compare
efriis
reviewed
Jan 24, 2025
cbornet
force-pushed
the
ruff-core-tch
branch
from
91555d0 to
defb8a5
Compare
I excluded TC001,TC002 and TC003 in be64878 so there won't be conflicts with Pydantic. |
cbornet
force-pushed
the
ruff-core-tch
branch
from
e096282 to
be64878
Compare
# Conflicts: # libs/core/langchain_core/utils/function_calling.py # libs/core/pyproject.toml # libs/core/tests/unit_tests/language_models/chat_models/test_base.py
ccurme
approved these changes
Feb 26, 2025
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#flake8-type-checking-tc
Some fixes done for TC001,TC002 and TC003 but these rules are excluded since they don't play well with Pydantic.