Adding some pytest best practices #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding dockerfile to run tests in - mostly generalizing .gitignore for any place in repo - adding pytest.ini to configure pytest - renaming home.py to match pytest.ini (default pytest) convention
- using base_url fixture instead of function + variable assignment
- updated teh cod based on new fixtures
elreydetoda
changed the title
|
closing because of new commits added to the PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to merge this one first: #4
This is just kind of a pytest best practices modification (at least according to the pytest class I took a while back), so I've mainly migrated a bunch of the variables you had inside your functions to be used inside the conftest.py. This allows them to be accessible by any test by passing them as a parameter (fixture) to the test.