Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicIP not removed after deleting LoadBalancer service #59255

Closed
feiskyer opened this issue Feb 2, 2018 · 2 comments · Fixed by #59340
Closed

PublicIP not removed after deleting LoadBalancer service #59255

feiskyer opened this issue Feb 2, 2018 · 2 comments · Fixed by #59340
Assignees
@feiskyer
Labels
area/cloudprovider kind/bug Categorizes issue or PR as related to a bug.

Comments

@feiskyer
Copy link
Member

feiskyer commented Feb 2, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:

When creating many LoadBalancer services, some services may exceed Azure basic LB's FrontendIPConfiguations quota (default is 10). Public IPs are created for all services, but it is not removed after deleting the kubernetes services.

I0202 08:50:13.986196       1 service_controller.go:725] Service has been deleted default/nginx35. Attempting to cleanup load balancer resources
E0202 08:50:13.986573       1 service_controller.go:218] error processing service default/nginx35 (will retry): Expected to find an IP address for service nginx35 but did not
I0202 08:50:13.986618       1 event.go:218] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"nginx35", UID:"eb4d9e3f-07eb-11e8-bb1d-000d3a19c1da", APIVersion:"v1", ResourceVersion:"3794301", FieldPath:""}): type: 'Normal' reason: 'DeletingLoadBalancer' Deleting load balancer
I0202 08:50:13.986759       1 event.go:218] Event(v1.ObjectReference{Kind:"Service", Namespace:"default", Name:"nginx35", UID:"eb4d9e3f-07eb-11e8-bb1d-000d3a19c1da", APIVersion:"v1", ResourceVersion:"3794301", FieldPath:""}): type: 'Warning' reason: 'DeletingLoadBalancerFailed' Error deleting load balancer (will retry): Expected to find an IP address for service nginx35 but did not

What you expected to happen:

Remove the public IP.

How to reproduce it (as minimally and precisely as possible):

Create more than 10 LoadBalancer services, wait a while for 10 services success, and then remove all services.

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/bug Categorizes issue or PR as related to a bug. labels Feb 2, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Feb 2, 2018

/sig azure

@k8s-ci-robot k8s-ci-robot added sig/azure and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 2, 2018
@feiskyer feiskyer self-assigned this Feb 2, 2018
@jhorwit2
Copy link
Contributor

jhorwit2 commented Feb 2, 2018

/area cloudprovider

@feiskyer feiskyer mentioned this issue Feb 5, 2018
Merged
monopole pushed a commit to monopole/kubernetes that referenced this issue Feb 6, 2018
Merge pull request kubernetes#59340 from feiskyer/fip
87f77cd 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Ensure public IP removed after service deleted

**What this PR does / why we need it**:

When creating many LoadBalancer services, some services may exceed Azure basic LB's FrontendIPConfiguations quota (default is 10). Public IPs are created for all services, but it is not removed after deleting the kubernetes services.

This PR fixes the problem.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes#59255

**Special notes for your reviewer**:

Should cherry-pick to v1.9.

**Release note**:

```release-note
Ensure Azure public IP removed after service deleted
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feiskyer feiskyer

Labels
area/cloudprovider kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure public IP removed after service deleted feiskyer/kubernetes
3 participants
@feiskyer @jhorwit2 @k8s-ci-robot