-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Namespace-awareness for CRDs #4189
Improve Namespace-awareness for CRDs #4189
Conversation
eloyekunle
commented
Aug 9, 2019
- On the backend, only filter CRDs by namespace if namespace-scoped.
- On the frontend, adds a new page for cluster-scoped CRD objects.
Codecov Report
@@ Coverage Diff @@
## master #4189 +/- ##
==========================================
+ Coverage 46.33% 46.34% +0.01%
==========================================
Files 198 198
Lines 9159 9159
Branches 105 105
==========================================
+ Hits 4244 4245 +1
+ Misses 4656 4655 -1
Partials 259 259
Continue to review full report at Codecov.
|
c88b033
to
74c1726
Compare
74c1726
to
6e8f7a1
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloyekunle, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |