-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create plugin/base branch to act as boilerplate for new plugins #4013
Conversation
b908302
to
35bf5f2
Compare
Codecov Report
@@ Coverage Diff @@
## plugin/base #4013 +/- ##
============================================
Coverage 47.28% 47.28%
============================================
Files 182 182
Lines 8400 8400
Branches 71 71
============================================
Hits 3972 3972
Misses 4183 4183
Partials 245 245 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## plugin/base #4013 +/- ##
==============================================
+ Coverage 46.18% 46.4% +0.22%
==============================================
Files 194 188 -6
Lines 8999 8708 -291
Branches 83 71 -12
==============================================
- Hits 4156 4041 -115
+ Misses 4587 4417 -170
+ Partials 256 250 -6
Continue to review full report at Codecov.
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e83db1b
to
b908302
Compare
b908302
to
e652bb0
Compare
PTAL @floreks @maciaszczykm |
Checking it. |
/approve LGTM if okay for you. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajatprabha, floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is in an early stage to close #1832
What's Missing:
...and a lot of other things which shall be added as progress is made.