Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plugin/base branch to act as boilerplate for new plugins #4013

Merged
merged 4 commits into from
Sep 5, 2019

Conversation

ajatprabha
Copy link
Contributor

@ajatprabha ajatprabha commented Jul 3, 2019

This PR is in an early stage to close #1832

What's Missing:

  • Installation and serving mechanism from the backend(Plugin controller to manage plugin source from dashboard backend #4017)
  • Ability to import and mount bundled plugin in the browser based on a config generated by the backend
  • Support plugins on the backend as a CRD for easy installation
  • Error Handling
    ...and a lot of other things which shall be added as progress is made.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2019
@ajatprabha ajatprabha mentioned this pull request Jul 8, 2019
3 tasks
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 23, 2019
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #4013 into plugin/base will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           plugin/base    #4013   +/-   ##
============================================
  Coverage        47.28%   47.28%           
============================================
  Files              182      182           
  Lines             8400     8400           
  Branches            71       71           
============================================
  Hits              3972     3972           
  Misses            4183     4183           
  Partials           245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea302e...35bf5f2. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #4013 into plugin/base will increase coverage by 0.22%.
The diff coverage is 25.31%.

Impacted file tree graph

@@              Coverage Diff               @@
##           plugin/base   #4013      +/-   ##
==============================================
+ Coverage        46.18%   46.4%   +0.22%     
==============================================
  Files              194     188       -6     
  Lines             8999    8708     -291     
  Branches            83      71      -12     
==============================================
- Hits              4156    4041     -115     
+ Misses            4587    4417     -170     
+ Partials           256     250       -6
Impacted Files Coverage Δ
src/app/backend/api/types.go 56% <ø> (ø) ⬆️
...tend/common/components/workloadstatus/component.ts 87.5% <ø> (ø) ⬆️
...ckend/resource/customresourcedefinition/objects.go 0% <0%> (ø) ⬆️
...ackend/resource/customresourcedefinition/client.go 0% <0%> (ø) ⬆️
...ackend/resource/customresourcedefinition/detail.go 0% <0%> (ø) ⬆️
...rc/app/backend/resource/common/resourcechannels.go 0% <0%> (ø) ⬆️
...ackend/resource/customresourcedefinition/events.go 100% <100%> (ø) ⬆️
src/app/frontend/overview/component.ts 56.86% <100%> (-13.73%) ⬇️
...ackend/resource/customresourcedefinition/common.go 20.83% <20.83%> (+1.96%) ⬆️
src/app/backend/handler/apihandler.go 27.18% <21.05%> (+0.1%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9353788...51162d5. Read the comment docs.

@k8s-ci-robot k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 23, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 23, 2019
@ajatprabha ajatprabha force-pushed the plugin/base branch 2 times, most recently from e83db1b to b908302 Compare August 23, 2019 20:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 2, 2019
@ajatprabha
Copy link
Contributor Author

PTAL @floreks @maciaszczykm

@maciaszczykm
Copy link
Member

Checking it.

@maciaszczykm
Copy link
Member

/approve
/cc @floreks

LGTM if okay for you.

@k8s-ci-robot k8s-ci-robot requested a review from floreks September 5, 2019 07:08
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@floreks
Copy link
Member

floreks commented Sep 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajatprabha, floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a2faef9 into kubernetes:plugin/base Sep 5, 2019
@ajatprabha ajatprabha mentioned this pull request Nov 21, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants