Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-976: Support Groups of Pods Where Driver Generates Workers in Pod Integration #4102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

everpeace
Copy link

@everpeace everpeace commented Jan 30, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1656

Special notes for your reviewer:

  • I'm not regular contributor of Kueue. Thus, I'm not so confident my PR is the relevant impelmentation for the KEP. Please feel free to correct me 🙇
  • I will support Kubeflow Spark Operator integration for the next step (SparkApplication integration)

Does this PR introduce a user-facing change?

KEP-976: Support Groups of Pods Where Driver Generates Workers in Pod Integration

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everpeace
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2025
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit f0d2aac
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67bf1e1d9a854b000800073b

@everpeace everpeace changed the title [WIP] KEP-976(story 3): Driver Generated Pods Support in Pod Integration [WIP] KEP-976: Support Groups of Pods Where Driver Generates Workers in Pod Integration Jan 30, 2025
@everpeace
Copy link
Author

/test all

@everpeace everpeace marked this pull request as ready for review February 19, 2025 23:50
@everpeace everpeace changed the title [WIP] KEP-976: Support Groups of Pods Where Driver Generates Workers in Pod Integration KEP-976: Support Groups of Pods Where Driver Generates Workers in Pod Integration Feb 19, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@everpeace everpeace marked this pull request as draft February 20, 2025 00:04
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
@everpeace everpeace marked this pull request as ready for review February 26, 2025 13:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2025
Copy link
Author

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, altghouth docs are not paved yet for this feature, I'd like to get a review for the implementation before I proceed to write user docs.

Thanks, in advance.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod Groups: Driver contains information about remaining Pods
2 participants