feat: Improve subnet and VPC finalizer handling #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
Pull Request Test Coverage Report for Build 13782658946Details
💛 - Coveralls |
dosubot
bot
added
size:M
oilbeater
force-pushed
the
fix/vpc-del
branch
3 times, most recently
from
3b88d9c to
9592246
Compare
- Add finalizer to subnet and VPC resources if not present - Remove VPC finalizer when no subnets exist - Enhance VPC status management by adding subnets to queue when empty - Use slices.Contains for more idiomatic finalizer checks Signed-off-by: Mengxin Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #5068