Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: consider StatefulSet's start ordinal #4967

Merged
merged 1 commit into from
Feb 6, 2025
Merged

controller: consider StatefulSet's start ordinal #4967

merged 1 commit into from
Feb 6, 2025

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #4955

@zhangzujian zhangzujian marked this pull request as ready for review February 6, 2025 03:04
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement Improve exist functions labels Feb 6, 2025
@coveralls
Copy link

coveralls commented Feb 6, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13171496095

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 22.335%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/pod.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/ovs/ovn-nb-logical_router_route.go 2 74.93%
Totals Coverage Status
Change from base Build 13170768503: -0.002%
Covered Lines: 10376
Relevant Lines: 46456
💛 - Coveralls

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 6, 2025
@zhangzujian zhangzujian changed the title controller: consider StatefulSet's ordinals controller: consider StatefulSet's start ordinal Feb 6, 2025
@zhangzujian zhangzujian added bug Something isn't working and removed enhancement Improve exist functions labels Feb 6, 2025
@zhangzujian zhangzujian merged commit 2a1239f into kubeovn:master Feb 6, 2025
65 of 68 checks passed
@zhangzujian zhangzujian deleted the fix-sts-ordinals branch February 6, 2025 04:45
zhangzujian added a commit that referenced this pull request Feb 6, 2025
@zhangzujian
controller: consider StatefulSet's start ordinal (#4967)
a6123dd 
Signed-off-by: zhangzujian <[email protected]>
zhangzujian added a commit that referenced this pull request Feb 6, 2025
@zhangzujian
controller: consider StatefulSet's start ordinal (#4967)
1ad46be 
Signed-off-by: zhangzujian <[email protected]>
zhangzujian added a commit that referenced this pull request Feb 6, 2025
@zhangzujian
controller: consider StatefulSet's start ordinal (#4967)
3fc588c 
Signed-off-by: zhangzujian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working need backport size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] statefulset scaled down condition not right
2 participants
@zhangzujian @coveralls