Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: check condition NodeNetworkUnavailable when determining whether node is ready #4917

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12705395739

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 22.053%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/node.go 0 8 0.0%
Totals Coverage Status
Change from base Build 12687680923: -0.001%
Covered Lines: 10164
Relevant Lines: 46089

💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review January 10, 2025 08:24
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 10, 2025
@zhangzujian zhangzujian requested a review from oilbeater January 10, 2025 08:45
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 10, 2025
@zhangzujian zhangzujian merged commit d260853 into kubeovn:master Jan 11, 2025
67 of 68 checks passed
@zhangzujian zhangzujian deleted the node-ready branch January 11, 2025 10:02
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jan 11, 2025
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jan 11, 2025
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer need backport size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants