fix(controller/subnet): controller crashes on subnets if gateway is u… #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nspecified and netpol are disabled Signed-off-by: SkalaNetworks <[email protected]>
dosubot
bot
added
size:S
Pull Request Test Coverage Report for Build 12389891825Details
💛 - Coveralls |
zbb88888
reviewed
Dec 19, 2024
| for _, np := range policies { | ||
| c.enqueueAddNp(np) | ||
| // Trigger network policy refresh only if they are enabled, otherwise the lister will be nil | ||
| if c.npsLister != nil { |
There was a problem hiding this comment.
how about using ?
if c.npsLister == nil {
log
return
}
oilbeater
pushed a commit
that referenced
this pull request
Dec 24, 2024
…nspecified and netpol are disabled (#4848) Signed-off-by: SkalaNetworks <[email protected]>
oilbeater
pushed a commit
that referenced
this pull request
Dec 24, 2024
…nspecified and netpol are disabled (#4848) Signed-off-by: SkalaNetworks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR references #4841