Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some compute are done when services are instantiated (e.g. injected). Better to compute only if the service is really used.
Why did I do that? Multiple reasons:
composer install
, page rendering, etc...) without having acredentials.json
Plus some optimizations:
ProjectFactory
service do not needFactory
factory injection (no argument in its constructor).ProjectFactory::createFactory
if we really want a new instance, usenew
instead ofclone
to ensure it.Checklist: