fix: Check all relevant pre-release versions, not just the latest. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanty
added
🐛 bug
Shadow53
requested changes
Dec 24, 2022
dbanty
force-pushed
the
334-handle-pre-too-new
branch
from
4167f39 to
aeca427
Compare
BREAKING CHANGE: Handling of pre-release versions has been reworked to handle many more edge cases which results in more correct (but different) behavior. Closes #334
Co-authored-by: Michael Bryant <[email protected]>
Co-authored-by: Michael Bryant <[email protected]>
Co-authored-by: Michael Bryant <[email protected]>
BREAKING CHANGE: Handling of pre-release versions has been reworked to handle many more edge cases which results in more correct (but different) behavior. Closes #334
dbanty
force-pushed
the
334-handle-pre-too-new
branch
from
aeca427 to
e4ea303
Compare
|
@Shadow53 I think I fixed all the things, please take another look when you get a chance |
|
Merging this as-is since I think it fixes the bug. We can always improve the code more later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Handling of pre-release versions has been reworked to handle many more edge cases which results in more correct (but different) behavior.
Closes #334