Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sourcepos for setext headers #381

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix sourcepos for setext headers #381

merged 1 commit into from
Apr 26, 2024

Conversation

digitalmoksha
Copy link
Collaborator

Setext heading sourccpos was off by one line.

Closes #378

@digitalmoksha digitalmoksha linked an issue Apr 25, 2024 that may be closed by this pull request
Incorrect sourcepos for Setext headings #378
Closed
@github-actions GitHub Actions
Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-69060a9 319.7 ± 1.4 317.4 324.1 2.87 ± 0.02
./bench.sh ./comrak-main 321.0 ± 1.7 318.3 325.9 2.89 ± 0.02
./bench.sh ./pulldown-cmark 111.2 ± 0.6 110.0 113.0 1.00
./bench.sh ./cmark-gfm 118.4 ± 1.0 117.1 121.6 1.06 ± 0.01
./bench.sh ./markdown-it 483.9 ± 8.4 478.1 513.4 4.35 ± 0.08

Run on Thu Apr 25 22:27:53 UTC 2024

@digitalmoksha digitalmoksha requested a review from kivikakk April 25, 2024 22:30
@kivikakk
Copy link
Owner

Perfect, thank you! ❤️

@kivikakk kivikakk merged commit c653b57 into main Apr 26, 2024
25 checks passed
@kivikakk kivikakk deleted the 378-incorrect-sourcepos-for-setext-headings branch April 26, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivikakk kivikakk Awaiting requested review from kivikakk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect sourcepos for Setext headings
2 participants
@digitalmoksha @kivikakk