[#26] Footnotes support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is extension "footnotes" in cmark-gfm, that was unsupported by this lib It extends a Node type with footnotes (like `[^1`) I added `FOOTNOTE_DEFINITION` and `FOOTNOTE_REFERENCE` to `Node` Internally it is an option, so I exposed it as an option, maybe it should be pseudo-extension instead
|
Thank you so much! I added a test to make sure this doesn't regress in the future. The I think it's fine to leave options exposed as options and extensions exposed as extensions. This is a very (very) thin wrapper, and I'm happy for it to remain that way. Let me know if you want a new release on Hackage for this. |
@kivikakk That would be great, thanks |
|
Done! 0.2.5 is now on Hackage: https://hackage.haskell.org/package/cmark-gfm-0.2.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is extension "footnotes" in cmark-gfm, that was unsupported by this lib
It extends a Node type with footnotes (like
[^1)I added
FOOTNOTE_DEFINITIONandFOOTNOTE_REFERENCEtoNodeInternally it is an option, so I exposed it as an option,
maybe it should be pseudo-extension instead