Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature to track every validators in the pool #94

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

qj0r9j0vc2
Copy link

Add feature to track every validators in the pool.

to track every validators, the chain should have staking module.

@qj0r9j0vc2 qj0r9j0vc2 changed the title feat: Add flag to track every validators in the pool feat: add feature to track every validators in the pool Feb 4, 2025
@MattKetmo
Copy link
Member

Hello, thanks for your contribution.

I don't think I'll merge it as is, since I see some issues with doing it that way.

  • The output should be muted; displaying a row with 100+ validators doesn't make much sense.
  • Extracting commissions + votes for each validator for each proposal could lead to too many requests to RPCs, especially if using a public one.

In my opinion, it makes sense to extract already available data, i.e., attested and missed blocks for each validator, but skip all other parts.

That would be an option to fill metrics without displaying more information in the CLI output (i.e., only --validator should be displayed).

Is this what you wanted to achieve with this PR (getting the uptime of all validators)?

Note that I'd also like to work on exposing the average and percentiles of uptime in order to compare the performance of our validators versus the network, but without the need to store all validators' uptime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants