-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing ClusterRole, ClusterRoleBinding, and ServiceAccount for Custom Cert Mode in Helm Chart #6188
base: master
Are you sure you want to change the base?
Conversation
…e in Helm Chart Signed-off-by: wei-chenglai <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6188 +/- ##
=======================================
Coverage 47.97% 47.97%
=======================================
Files 674 674
Lines 55841 55841
=======================================
+ Hits 26788 26789 +1
+ Misses 27305 27304 -1
Partials 1748 1748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @zhzhuang-zju and @RainbowMango , please help review this PR when you have time. Thank you so much! |
/lgtm |
Hi @zhzhuang-zju , agree! I could add a Chart test for custom cert mode in the subsequent reinforcement. |
cc @a7i to take another look and approval? |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When installing Karmada using the Helm chart with
certs.mode
set tocustom
, the requiredClusterRole
,ClusterRoleBinding
, andServiceAccount
are not created: https://github.com/karmada-io/karmada/blob/master/charts/karmada/templates/pre-install-job.yaml#L449-L498.These resources are essential for the static-resource-job, post-delete-job, and post-install-job to function correctly.
To resolve this issue, the installation of these resources has been moved outside the certificate mode conditional check, ensuring they are created regardless of the selected certificate mode.
Which issue(s) this PR fixes:
Fixes #6185
Special notes for your reviewer:
Does this PR introduce a user-facing change?: