Update Incorrect inheritance #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadenzipfel
requested changes
Jul 28, 2024
Comment on lines
+11
to
+47
| ```solidity | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.16; | ||
|
|
||
| contract Final { | ||
| uint public a; | ||
| constructor(uint f) { | ||
| a = f; | ||
| } | ||
| } | ||
|
|
||
| contract B is Final { | ||
| int public fee; | ||
|
|
||
| constructor(uint f) Final(f) { | ||
| } | ||
| function setFee() public { | ||
| fee = 3; | ||
| } | ||
| } | ||
|
|
||
| contract C is Final { | ||
| int public fee; | ||
|
|
||
| constructor(uint f) Final(f) { | ||
| } | ||
| function setFee() public { | ||
| fee = 5; | ||
| } | ||
| } | ||
|
|
||
| contract A is B, C { | ||
| constructor() B(3) C(5) { | ||
| setFee(); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
This example doesn't compile for me:
DeclarationError: Identifier already declared.
--> contracts/Linearization.sol:18:5:
|
18 | int public fee;
| ^^^^^^^^^^^^^^
Note: The previous declaration is here:
--> contracts/Linearization.sol:10:5:
|
10 | int public fee;
| ^^^^^^^^^^^^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the changes you've made:
Updated the "Incorrect inheritance" issue with example and mitigation's.
Type of change
Select the appropriate checkbox: