Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix clippy lints and some minor CI/documentation updates #110

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

jfrimmel
Copy link
Owner

See the individual commits for details.

Unfortunately, some new versions may change behavior, e.g. clippy may
add lints, which break the build. Therefore it makes sense, to pin
certain error prone CI-jobs to some specific versions. They should be
bumped regularly, though.

Currently, the following jobs are pinned:
1. the `ci/test`-job: as shown in #105, Rust 1.83 has introduced a valid
   "leak", which fails our tests for now. Therefore this job is pinned
   to 1.82, where this issue doesn't occur. A proper fix is necessary in
   the future (#107).
2. `clippy`: the latest [PR broke the clippy job][clippy-job] due to new
   lints being fired. Therefore the CI is pinned to 1.83 with the issues
   fixed.

[clippy-job]: https://github.com/jfrimmel/cargo-valgrind/actions/runs/12095283463/job/33728289241
@jfrimmel jfrimmel merged commit ad39621 into master Nov 30, 2024
20 checks passed
@jfrimmel jfrimmel deleted the chore branch November 30, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant