Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatching tag names #88

Closed
jfrimmel opened this issue Sep 17, 2024 · 0 comments · Fixed by #89
Closed

Mismatching tag names #88

jfrimmel opened this issue Sep 17, 2024 · 0 comments · Fixed by #89

Comments

@jfrimmel
Copy link
Owner

Currently the tags are all named x.y.z, except for v2.1.0 and v2.1.1 (they have a leading v). Note, that the workflows are contradicting:

  1. the current release-workflow forces a tag name without the v:

    VERSION: ${{ github.event.inputs.version }}

    sed -i "0,/version = /{s/^version = .*$/version = \"${VERSION}\"/}" Cargo.toml
  2. the current deploy-workflow only runs on a tag name with the v:

This causes the latest release to not include any artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant