Update for new header #194
Conversation
This reverts commit 6da3e50.
| </j:if> | ||
| <script src="${resURL}/plugin/customizable-header/js/messages.js" type="text/javascript"></script> |
There was a problem hiding this comment.
should that not stay on the line it had been , since you only want to import the js when you are using it.enabled
There was a problem hiding this comment.
Thinking was that you might want system messages without changing anything else about the header.
| return header; | ||
| } | ||
| return new JenkinsHeaderSelector(); | ||
| // TODO - come back to this |
| } | ||
| } | ||
|
|
||
| // TODO - this should be combined with CustomHeaderConfiguration#401 |
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| // TODO - this should be combined with CustomHeaderConfiguration#407 |
|
Outside of the TODOs remaining, any thoughts on this @mawinter69? |
| <j:if test="${link.type == 'link'}"> | ||
| <a href="${link.url}" class="jenkins-dropdown__item"> | ||
| <div class="jenkins-dropdown__item__icon"> | ||
| <j:out value="${link.iconXml}" escapeText="false" /> |
There was a problem hiding this comment.
iconXML might not be defined, e.g. when the chosen image is not a symbol but a simple png
There was a problem hiding this comment.
Actually the content aware header previously still allowed to define a default logo. So what we would need is more something like a logo behaviour (static, content aware (with the suboptions to show the weather). I even have some branch with a random logo where I used all the SVG found at https://www.jenkins.io/artwork/
|
What I would like to be able to do is having a header like it was possible before |
This PR updates the plugin to be compatible with the [new Jenkins header]. The thinking behind this PR is to minimise the need for completely overriding the header, instead relying on replaceable slots in core's header. This will make it easier to update core in the future, without risk of breaking/impacting this plugin.
I've also added some examples themes to the plugin, demonstrating it's customizability and also making it easy for users to revert to the classic header theme if they prefer.
Testing done
Submitter checklist