Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a temp directory for input and output files #1807

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

richafrank
Copy link
Contributor

Use a temp directory for input and output files when testing sync, so the working directory remains clean.

As per discussion in #1802 (comment)

I considered changing each test to pass to cli an explicit path to a requirements file in a temp dir, but the autouse fixture seemed more robust to adding new tests that might forget and also continues to test the default reqs file.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

when testing sync, so the working directory remains clean.
@richafrank richafrank added tests Testing and related things skip-changelog Avoid listing in changelog labels Feb 2, 2023
@richafrank richafrank requested a review from atugushev February 2, 2023 19:19
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks 🎉

@atugushev atugushev enabled auto-merge (squash) February 20, 2023 16:09
@atugushev atugushev merged commit bce5b24 into jazzband:main Feb 20, 2023
@richafrank richafrank deleted the test_cli_sync-tmp_path branch February 20, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants