Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoimport from firefox with several installed editions #711

Closed
elig0n opened this issue Jan 23, 2024 · 1 comment · Fixed by #716
Closed

Autoimport from firefox with several installed editions #711

elig0n opened this issue Jan 23, 2024 · 1 comment · Fixed by #716

Comments

@elig0n
Copy link

elig0n commented Jan 23, 2024

I have both Firefox and Firefox Developer Edition installed on my machine.
~/.mozilla/firefox/profiles.ini lists two [Install*] sections with two different default profiles for each Firefox edition.
The current code in master branch only utilizes the first section in order, which in my case is not my desired profile.

Possible solutions:

  1. Allow to directly specify firefox profile full name/directory on the command line.
  2. Return an array of install_names with "default" keys in get_firefox_profile_name() and either use all of them one by one or ask the user to interactively choose one.
  3. Use [Profile*] sections only, skipping [Installs*] completely and default to selecting the last used profile (i.e. the one with Default=1)
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Feb 5, 2024
@LeXofLeviafan
Copy link
Collaborator

Haven't tried the import feature before, but the issue turns out to be fully reproducible on my system (I have a Dev version of Firefox installed for – you've guessed it – development purposes, and that install is listed before the one I actually use for web-surfing).

That being said, the 3rd approach would fail on my system (the profile marked as default is empty for some reason).

Providing profile name via environment variable (e.g. FIREFOX_PROFILE="blahblah.default-release" buku --ai) is pretty trivial to implement, though the UX might be inconvenient…

The currently existing implementation already asks for user input (unless in library mode, I guess), so I tried implementing the 2nd one (offering to choose when multiple installs are detected, falling back to original behaviour in library mode); leaving the env var thing as a fallback.

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Feb 5, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Feb 5, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Feb 5, 2024
jarun added a commit that referenced this issue Feb 17, 2024
[#711] fixed profile detection for multiple Firefox installs
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants