Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for bukuserver #644

Closed
LeXofLeviafan opened this issue Dec 14, 2022 · 4 comments · Fixed by #650
Closed

Dark mode for bukuserver #644

LeXofLeviafan opened this issue Dec 14, 2022 · 4 comments · Fixed by #650

Comments

@LeXofLeviafan
Copy link
Collaborator

The app doesn't have a dark (night?) mode; this could be rectified by either modifying the current theme, creating a UI dark mode toggle (probably the hardest to implement), or by replacing the theme file at startup via server configuration.

For example, one of these themes could be used (they have MIT license); out of the list, the following are dark: Cyborg, Darkly, Slate, Superhero. (Slate seems to have a softer contrast while retaining a look similar to the currently used / default theme.)

Additionally, depending on the used mechanism (i.e. whether their repo can be used as a pip dependency – perhaps optional?), it might be possible to extend this functionality further by allowing to set any of those themes in the config (as opposed to just toggling on or off the dark one).

@jarun
Copy link
Owner

jarun commented Dec 14, 2022

Themes are good! I'm all in!

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Dec 14, 2022
@LeXofLeviafan
Copy link
Collaborator Author

…Turns out, there's builtin support (for these specific themes, even) in flask-admin 😅

@Butterfly
Copy link

The app doesn't have a dark (night?) mode; this could be rectified by either modifying the current theme, creating a UI dark mode toggle (probably the hardest to implement), or by replacing the theme file at startup via server configuration.

This kind of discussion is always a personal favorite. It touches on accessibility and usability for people with vision-related disabilities.

Rather than post two comments, will just also mention here that going that extra mile to spend time on e.g. PR #655 (adding how-to examples for users) is a huge help for persons with cognitive disabilities, too. Adding related printscreen/screenshot images puts it over the top. Thank you, Team buku! 💃

@LeXofLeviafan
Copy link
Collaborator Author

This kind of discussion is always a personal favorite. It touches on accessibility and usability for people with vision-related disabilities.

Well, my pull request (#650) is just using the builtin theme set – so it's up to the user to decide (and it actually does work by replacing the theme file at startup as that's how it's designed in Bootstrap).

going that extra mile to spend time on e.g. PR #655 (adding how-to examples for users) is a huge help for persons with cognitive disabilities

It's helpful for literally everyone trying to understand how to use the tool except for maybe those who designed the CLI (and thus already know how it works) 😅
Clarity is simply a property that lets the docs convey information better, in general.

As for that particular pull request, the point was to document a certain aspect of core behaviour (duplicate URLs are not allowed) which was never mentioned before despite potentially affecting the tool usage.

@jarun jarun closed this as completed in #650 Jan 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants