-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode for bukuserver #644
Comments
Themes are good! I'm all in! |
…Turns out, there's builtin support (for these specific themes, even) in flask-admin 😅 |
This kind of discussion is always a personal favorite. It touches on accessibility and usability for people with vision-related disabilities. Rather than post two comments, will just also mention here that going that extra mile to spend time on e.g. PR #655 (adding how-to examples for users) is a huge help for persons with cognitive disabilities, too. Adding related printscreen/screenshot images puts it over the top. Thank you, Team buku! 💃 |
Well, my pull request (#650) is just using the builtin theme set – so it's up to the user to decide (and it actually does work by replacing the theme file at startup as that's how it's designed in Bootstrap).
It's helpful for literally everyone trying to understand how to use the tool except for maybe those who designed the CLI (and thus already know how it works) 😅 As for that particular pull request, the point was to document a certain aspect of core behaviour (duplicate URLs are not allowed) which was never mentioned before despite potentially affecting the tool usage. |
The app doesn't have a dark (night?) mode; this could be rectified by either modifying the current theme, creating a UI dark mode toggle (probably the hardest to implement), or by replacing the theme file at startup via server configuration.
For example, one of these themes could be used (they have MIT license); out of the list, the following are dark: Cyborg, Darkly, Slate, Superhero. (Slate seems to have a softer contrast while retaining a look similar to the currently used / default theme.)
Additionally, depending on the used mechanism (i.e. whether their repo can be used as a pip dependency – perhaps optional?), it might be possible to extend this functionality further by allowing to set any of those themes in the config (as opposed to just toggling on or off the dark one).
The text was updated successfully, but these errors were encountered: