Design an icon for the server

[piegamesde]

Buku does not appear to have an icon yet. It would be cool if it had one, especially for use in the server? For reference, this is what the browser extension uses:

[jarun]

A bigger version of 🔖 can be used.

[piegamesde]

While trying to add an icon I noticed this line: https://github.com/jarun/buku/blob/master/bukuserver/templates/bukuserver/base.html#L7

Not only does it make little sense to me (the base64 content literally says "PNG" with some encoding errors and nothing more), that line also does not show up in the running server's HTML output.

[rachmadaniHaryono]

that is based on this https://stackoverflow.com/a/13416784

[LeXofLeviafan]

…Why is this closed? The issue still exists in the current codebase, and it doesn't seem to have got a "wontfix" response either.

that is based on this https://stackoverflow.com/a/13416784

This answers the first part of his remark, but not the second one (about the line not showing up anywhere).
…The answer to that one would be "this file isn't actually used anymore".

[LeXofLeviafan]

A bigger version of 🔖 can be used.

What's the license of this image? It's a GitHub asset; can it actually be repurposed?

…As for bukubrow-webext, it appears to be licensed under GPL v3, so I'm guessing reusing their asset should be viable as long as it's acknowledged (though perhaps they're using an asset published elsewhere under CC?).

[piegamesde]

Instead of using that icon, I suggest simply using the emoji as-is, optionally with specifying the font:

<!-- favicon.svg -->
<svg xmlns="http://www.w3.org/2000/svg">
  <text y="32" font-size="32">🔖</text>
</svg>

Most modern browsers support SVG favicons by now. This also easily avoids all licensing issues.

[jarun]

I agree with @piegamesde.

[LeXofLeviafan]

…This solution seems quite system-reliant, but I suppose it should work.

AFAIK to provide the icon for a flask-admin site, you need to either override/extend every single template used in the site, or provide the file as a static favicon.ico; so the idea needs some testing at the very least.

[LeXofLeviafan]

…Incidentally, I suggest changing description of DISABLE_FAVICON variable in bukuserver readme to "disable favicons" at the very least. Without plural, its purpose is rather unclear (the plural would at least clue in the reader that it's not about favicon of the site itself).

P.S. The bookmark favicons could also use a whitespace after them, BTW

[piegamesde]

This solution seems quite system-reliant, but I suppose it should work.

Well I just want an icon and personally I'd favor consistency with the system over consistency of the site across machines, but if you wanted that I think you could specify the font to use in the SVG file and then it would look the same everywhere.

its purpose is rather unclear

Yes I was quite confused about it, and only after trying it out I figured that it was about the favicon of the bookmarks.

[rachmadaniHaryono]

Yes I was quite confused about it, and only after trying it out I figured that it was about the favicon of the bookmarks.

there is edit to description after #631 merged

but i am more interested if new casual user know about favicon

@jarun if you post new release can you ask that? if not maybe add favicon description on bukuserver page for example from wiki

A favicon (/ˈfæv.ɪˌkɒn/; short for favorite icon), also known as a shortcut icon, website icon, tab icon, URL icon, or bookmark icon, is a file containing one or more small icons,[1] associated with a particular website or web page.

[LeXofLeviafan]

i am more interested if new casual user know about favicon

I'm pretty sure they're familiar with the concept (though perhaps not by name, so they might call it "site icon" or something), since it's the icon displayed in pretty much every tab next to the page title 😄

maybe add favicon description on bukuserver page for example from wiki

Methinks a hyperlink will do (i.e. "disable bookmark favicons")

[LeXofLeviafan]

…This issue is still not fixed in the code BTW, so I believe it should stay open until bukuserver in the master has a working favicon.