Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The content of details modal in bukuserver overflows #607

Closed
LeXofLeviafan opened this issue Nov 12, 2022 · 0 comments · Fixed by #622
Closed

The content of details modal in bukuserver overflows #607

LeXofLeviafan opened this issue Nov 12, 2022 · 0 comments · Fixed by #622
Labels

Comments

@LeXofLeviafan
Copy link
Collaborator

In the bookmarks list of bukuserver, each entry has a "details" button which opens a modal frame containing a table with bookmark details. In general case, when a row of this table contains long text, it's wrapped as a normal paragraph; however, if there's a long "word" (i.e. a string not containing whitespace), the table width gets stretched beyond the frame (with transparent background). This concerns two fields in particular: Url (which can easily be longer than 600px) and Tags (which have no spaces between them and thus are treated as a single "word" unless one of them contains a space by itself).

I have following suggestions:

  • Separate tags shown in the details table by placing spaces after commas (i.e. foo,bar,baz -> foo, bar, baz).
  • Apply a CSS rule on the 2nd column of details table to prevent overflows (i.e. overflow-wrap: anywhere or word-break: break-all). Such a rule does not necessarily require HTML modification; .modal-body tr > td:nth-child(2) works on existing layout.
    …Additionally, the same rule could be applied to the main table (i.e. td.col-Entry) to avoid the need for scrolling the table horizontally when one of the displayed URLs is too long (as it causes other data to fill in the overflowed width as well).
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Nov 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant