Skip to content

Commit

Permalink
Merge branch 'master' into add-groups-to-command-palette
Browse files Browse the repository at this point in the history
  • Loading branch information
janfaracik authored Feb 24, 2025
2 parents 1638afe + c37293c commit c0777db
Show file tree
Hide file tree
Showing 9 changed files with 35 additions and 25 deletions.
14 changes: 9 additions & 5 deletions .gitpod/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
FROM gitpod/workspace-full

FROM gitpod/workspace-full:latest
ARG JAVA_VERSION=21.0.6-tem
ARG MAVEN_VERSION=3.9.9

RUN brew install gh && \
bash -c ". /home/gitpod/.sdkman/bin/sdkman-init.sh && sdk install maven ${MAVEN_VERSION} && sdk default maven ${MAVEN_VERSION}"
# Install Java 21, Maven and GitHub CLI
RUN bash -c ". /home/gitpod/.sdkman/bin/sdkman-init.sh && \
sdk install java ${JAVA_VERSION} && \
sdk default java ${JAVA_VERSION} && \
sdk install maven ${MAVEN_VERSION} && \
sdk default maven ${MAVEN_VERSION} && \
brew install gh"
2 changes: 1 addition & 1 deletion core/src/main/java/jenkins/model/details/Detail.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* <li>SCM information for the build</li>
* <li>who kicked the build off</li>
* </ul>
* @since TODO
* @since 2.498
*/
public abstract class Detail implements ModelObject, IconSpec {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
/**
* Allows you to add multiple details to an Actionable object at once.
* @param <T> the type of object to add to; typically an {@link Actionable} subtype
* @since TODO
* @since 2.498
*/
public abstract class DetailFactory<T extends Actionable> implements ExtensionPoint {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ THE SOFTWARE.
clazz="${page.runs.isEmpty() and page.queueItems.isEmpty() ? 'jenkins-hidden' : ''}"/>

<div class="app-builds-container">
<div id="no-builds" class="app-builds-container__placeholder">
<div id="loading-builds" class="app-builds-container__placeholder">
<l:spinner text="${%Loading builds...}"/>
</div>
<div id="no-builds" style="display:none" class="app-builds-container__placeholder">
${%No builds}
</div>

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
"eslint": "9.20.1",
"eslint-config-prettier": "10.0.1",
"eslint-formatter-checkstyle": "8.40.0",
"globals": "15.15.0",
"globals": "16.0.0",
"handlebars-loader": "1.7.3",
"mini-css-extract-plugin": "2.9.2",
"postcss": "8.5.2",
"postcss": "8.5.3",
"postcss-loader": "8.1.1",
"postcss-preset-env": "10.1.4",
"postcss-scss": "4.0.9",
Expand Down
5 changes: 4 additions & 1 deletion src/main/js/pages/project/builds-card.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const ajaxUrl = buildHistoryPage.getAttribute("page-ajax");
const card = document.querySelector("#jenkins-builds");
const contents = card.querySelector("#jenkins-build-history");
const container = card.querySelector(".app-builds-container");
const loadingBuilds = card.querySelector("#loading-builds");
const noBuilds = card.querySelector("#no-builds");

// Pagination controls
Expand Down Expand Up @@ -58,6 +59,7 @@ function load(options = {}) {
if (responseText.trim() === "") {
contents.innerHTML = "";
noBuilds.style.display = "block";
loadingBuilds.style.display = "none";
updateCardControls({
pageHasUp: false,
pageHasDown: false,
Expand All @@ -69,7 +71,7 @@ function load(options = {}) {

// Show the refreshed builds list
contents.innerHTML = responseText;
noBuilds.style.display = "none";
loadingBuilds.style.display = "none";
behaviorShim.applySubtree(contents);

// Show the card controls
Expand Down Expand Up @@ -146,6 +148,7 @@ document.addEventListener("DOMContentLoaded", function () {
debouncedLoad();
});

container.classList.add("app-builds-container--loading");
load();

window.addEventListener("focus", function () {
Expand Down
4 changes: 2 additions & 2 deletions src/main/scss/components/_tabs.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use "../abstracts/mixins";

$border-radius: 100px;
$border-radius: 19px;

.tabBarFrame {
position: relative;
Expand Down Expand Up @@ -36,7 +36,7 @@ $border-radius: 100px;
display: flex;
align-items: center;
justify-content: center;
min-height: 36px;
min-height: 34px;
padding: 0 1.2rem;
border-radius: $border-radius;
color: var(--tabs-item-foreground);
Expand Down
4 changes: 2 additions & 2 deletions war/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -539,14 +539,14 @@ THE SOFTWARE.
<!-- dependency of jakarta-mail-api -->
<groupId>io.jenkins.plugins</groupId>
<artifactId>jakarta-activation-api</artifactId>
<version>2.1.3-1</version>
<version>2.1.3-2</version>
<type>hpi</type>
</artifactItem>
<artifactItem>
<!-- dependency of mailer -->
<groupId>io.jenkins.plugins</groupId>
<artifactId>jakarta-mail-api</artifactId>
<version>2.1.3-1</version>
<version>2.1.3-2</version>
<type>hpi</type>
</artifactItem>
<artifactItem>
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3970,10 +3970,10 @@ __metadata:
languageName: node
linkType: hard

"globals@npm:15.15.0":
version: 15.15.0
resolution: "globals@npm:15.15.0"
checksum: 10c0/f9ae80996392ca71316495a39bec88ac43ae3525a438b5626cd9d5ce9d5500d0a98a266409605f8cd7241c7acf57c354a48111ea02a767ba4f374b806d6861fe
"globals@npm:16.0.0":
version: 16.0.0
resolution: "globals@npm:16.0.0"
checksum: 10c0/8906d5f01838df64a81d6c2a7b7214312e2216cf65c5ed1546dc9a7d0febddf55ffa906cf04efd5b01eec2534d6f14859a89535d1a68241832810e41ef3fd5bb
languageName: node
linkType: hard

Expand Down Expand Up @@ -4389,14 +4389,14 @@ __metadata:
eslint: "npm:9.20.1"
eslint-config-prettier: "npm:10.0.1"
eslint-formatter-checkstyle: "npm:8.40.0"
globals: "npm:15.15.0"
globals: "npm:16.0.0"
handlebars: "npm:4.7.8"
handlebars-loader: "npm:1.7.3"
hotkeys-js: "npm:3.12.2"
jquery: "npm:3.7.1"
lodash: "npm:4.17.21"
mini-css-extract-plugin: "npm:2.9.2"
postcss: "npm:8.5.2"
postcss: "npm:8.5.3"
postcss-loader: "npm:8.1.1"
postcss-preset-env: "npm:10.1.4"
postcss-scss: "npm:4.0.9"
Expand Down Expand Up @@ -6126,14 +6126,14 @@ __metadata:
languageName: node
linkType: hard

"postcss@npm:8.5.2, postcss@npm:^8.4.33, postcss@npm:^8.4.38, postcss@npm:^8.5.1":
version: 8.5.2
resolution: "postcss@npm:8.5.2"
"postcss@npm:8.5.3, postcss@npm:^8.4.33, postcss@npm:^8.4.38, postcss@npm:^8.5.1":
version: 8.5.3
resolution: "postcss@npm:8.5.3"
dependencies:
nanoid: "npm:^3.3.8"
picocolors: "npm:^1.1.1"
source-map-js: "npm:^1.2.1"
checksum: 10c0/3044d49bc725029ab62292e8bf9849741251b95f3b754e191bf8b4025414d40ec3b4ac05c5a563d4b50060b5c8e96683eb4d783d8d8fa3867eb7b763cbe66127
checksum: 10c0/b75510d7b28c3ab728c8733dd01538314a18c52af426f199a3c9177e63eb08602a3938bfb66b62dc01350b9aed62087eabbf229af97a1659eb8d3513cec823b3
languageName: node
linkType: hard

Expand Down

0 comments on commit c0777db

Please sign in to comment.