Graceful shutdown #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorm-issuu
reviewed
Mar 25, 2024
| /// Shutdown channel. Used to indicate that we should start graceful shutdown. | ||
| /// The channel has capacity 1 as we only need to signal once to shutdown. | ||
| /// Missing messages on the channel doesn't matter. | ||
| shutdown: broadcast::Sender<()>, |
There was a problem hiding this comment.
Why not use a oneshot channel?
There was a problem hiding this comment.
I tried but oneshot is single-producer single-consumer, and we need to both send from multiple places (internally and the user can also) and we need to receive in multiple places (each handler) so the broadcast channel is the only one that satisfies that in tokio.
gorm-issuu
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app will now gracefully shut down when signalled through a broadcast channel. A convenience function is also added that automatically listens for ctrl-c (non-Unix) or SIGTERM, SIGINT and SIGHUP (Unix).