Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create buiphuan.json #20946

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Create buiphuan.json #20946

wants to merge 3 commits into from

Conversation

anbui0211
Copy link

  • I have read and understood the Terms of Service.
  • I understand my domain will be removed if I violate the Terms of Service.
  • My file is in the domains directory and has the .json file extension.
  • My file's name is lowercased and alphanumeric.
  • My website is reachable and completed.
  • I have provided sufficient contact information in the owner key.

Website Preview

@anbui0211 anbui0211 requested a review from a team as a code owner March 8, 2025 05:24
@github-actions github-actions bot added the domain label Mar 8, 2025
21Z
21Z requested changes Mar 8, 2025
View reviewed changes
domains/buiphuan.json Outdated
"email": "[email protected]"
},
"record": {
"URL": "anbui0211.github.io"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

website doesnt really contain anything
also, URL records should contain protocol

Suggested change
"URL": "anbui0211.github.io"
"URL": "https://anbui0211.github.io/"

Copy link
Author

@anbui0211 anbui0211 Mar 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@21Z

  1. I haven't started coding. I just got the idea to create a website.
  2. As your suggestion, I have changed the URL.
    Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't started coding. I just got the idea to create a website.

At least try to put something in your website, like an about me for example.

@21Z 21Z added reason: incomplete website There is little to no content on the site. reason: invalid records Your records are not valid or improper. labels Mar 8, 2025
@21Z 21Z removed the reason: invalid records Your records are not valid or improper. label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iostpa iostpa iostpa left review comments

@21Z 21Z 21Z requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
domain reason: incomplete website There is little to no content on the site.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anbui0211 @21Z @iostpa