Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update roshan.json #20936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update roshan.json #20936

wants to merge 1 commit into from

Conversation

roshan1885
Copy link
Contributor

Requirements

  • I have read and understood the Terms of Service.
  • I understand my domain will be removed if I violate the Terms of Service.
  • My file is in the domains directory and has the .json file extension.
  • My file's name is lowercased and alphanumeric.
  • My website is reachable and completed.
  • I have provided sufficient contact information in the owner key.

Website Preview

image

@roshan1885 roshan1885 requested a review from a team as a code owner March 7, 2025 23:13
@roshan1885
Copy link
Contributor Author

it was an abandoned domain
It would be great if I could get it.
If there's any issue, then please specify so that I can fix it at the earliest.
Thank You!

@github-actions github-actions bot added the domain label Mar 7, 2025
@21Z
Copy link
Member

21Z commented Mar 8, 2025

it was an abandoned domain It would be great if I could get it.

please contact the subdomain owner

21Z
21Z requested changes Mar 8, 2025
View reviewed changes
domains/roshan.json
Comment on lines +8 to +10
"CNAME": "roshan1885.github.io",
"MX": ["mx1.improvmx.com", "mx2.improvmx.com"],
"TXT": "v=spf1 include:spf.improvmx.com ~all"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can't use any other records with CNAME unless domain is proxied

@21Z 21Z added reason: invalid records Your records are not valid or improper. reason: other labels Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@21Z 21Z 21Z requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
domain reason: invalid records Your records are not valid or improper. reason: other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roshan1885 @21Z