Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: solve flake8 error causing ci to fail #64

Merged
merged 7 commits into from
Jan 4, 2023
Merged

fix: solve flake8 error causing ci to fail #64

merged 7 commits into from
Jan 4, 2023

Conversation

dluo96
Copy link
Contributor

@dluo96 dluo96 commented Jan 4, 2023 •
edited
Loading

Resolves #63 #62

  • Changed the default Python version in .pre-commit-config.yaml
  • Changed the version of flake8 in .pre-commit-config.yaml
  • Added a constraint on importlib-metadata in requirements-dev.txt and .pre-commit-config.yaml
  • Pinned flake8 in requirements-dev.txt
  • Suppressed a flake8 error around cognitive complexity

@dluo96 dluo96 requested a review from clement-bonnet January 4, 2023 16:25
@clement-bonnet clement-bonnet added bug Something isn't working ci labels Jan 4, 2023
@clement-bonnet clement-bonnet mentioned this pull request Jan 4, 2023
Closed
clement-bonnet
clement-bonnet requested changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we possibly tag flake8? To prevent this from happening again.

@dluo96 dluo96 changed the title fix: solve flake8 error causing ci to fail fix: pin flake8 and solve flake8 error causing ci to fail Jan 4, 2023
@dluo96 dluo96 changed the title fix: pin flake8 and solve flake8 error causing ci to fail fix: solve flake8 error causing ci to fail Jan 4, 2023
@dluo96 dluo96 merged commit 5cf8fcc into main Jan 4, 2023
@dluo96 dluo96 deleted the 62-fix-ci-bug branch January 4, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clement-bonnet clement-bonnet clement-bonnet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dluo96 @clement-bonnet