-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/type hints #215
Conversation
I developed and tested successfully on Python 3.8.10. Upon opening this PR, the tests seem to have failed for Python 3.9. When running mypy it finds 25 errors in 20 files (checked 297 source files). So, I ran mypy also on the latest commit that is not part of this PR (to check whether I introduced these issues), and the same number of errors were found. Can it be that the source code on main has not yet been tested for Python 3.9? If so, I think it's best to resolve these 25 issues in a different PR and block the current PR until the other one has successfully been merged. Thoughts? |
I'll have a look into the mypy issue 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 😄
My pleasure. I thought it's a good first issue. I see that you opened PR #216. Once that is approved, hopefully the linting is gonna pass here too and we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for the improvement!
This PR solves #95
Development environment