feat: removals #23
Open
feat: removals #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
Feb 26, 2025
| /// Remove a method from the router. | ||
| /// | ||
| /// If the route does not exist, this method is a no-op. | ||
| pub(crate) fn remove_route(mut self, method: Cow<'static, str>) -> Self { |
There was a problem hiding this comment.
I haven't thought deeply about how this should interact with aliasing. should removing a method also remove all aliases of it?
There was a problem hiding this comment.
I imagine as a user you would expect that most of the time, but I guess there is a case where you want to remove just the alias or just the method you aliased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Router::remove_routeto remove methods from the routerCloses #16