fix: errors from InfluxDB 1.8 being empty #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 78.88% 78.66% -0.22%
==========================================
Files 26 26
Lines 1776 1772 -4
==========================================
- Hits 1401 1394 -7
- Misses 247 250 +3
Partials 128 128
Continue to review full report at Codecov.
|
diamondburned
changed the title
vlastahajek
requested changes
Jun 25, 2020
There was a problem hiding this comment.
Thanks for the PR. LGTM.
Please, add a Changelog entry and a test (e.g. sth like this)
Squashed from 4 commits: - Added an HTTP error fallback to X-Influxdb-Error - Added a final default fallback for the HTTP Error - Added tests for Influx 1.8 and fallback errors - Added this PR to changelogs
|
I genuinely have no idea why the tests are failing somewhere else after only adding 2 more tests. |
vlastahajek
approved these changes
Jun 26, 2020
|
Thanks for the update. Don't worry about the tests. There is a change between beta 12 and beta 13 that made some tests failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes errors from InfluxDB 1.8 being empty. It does this by falling back to reading the
X-Influxdb-Error, and if that doesn't work, thenhttp.Errorwould return the unexpected status code inside the error message.Before PR:
After PR: