Website #646
Merged
Website #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvishnusankar
requested changes
May 25, 2023
There was a problem hiding this comment.
@trace2798 Thanks for this PR 🙏
Here're some suggestion:
- Rename
websitefolder todocs - Edit the root
package.jsonof main project and add the following inworkspacesentry:
{
"workspaces": {
"packages": [
"packages/*",
"examples/*",
"docs"
]
}
website/package.json
Outdated
| @@ -0,0 +1,30 @@ | |||
| { | |||
| "name": "website", | |||
website/next.config.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| /** @type {import('next').NextConfig} */ | |||
| const nextConfig = {} | |||
There was a problem hiding this comment.
Make the website static by adding output prop
/** @type {import('next').NextConfig} */
const nextConfig = {
output: 'export',
}
iamvishnusankar
requested changes
May 25, 2023
docs/package.json
Outdated
| "typescript": "5.0.4" | ||
| }, | ||
|
|
||
| "workspaces": { |
There was a problem hiding this comment.
Not here, add it on root package.json. This file
Lines 10 to 15 in cd9992b
There was a problem hiding this comment.
My bad got it now tho
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
iamvishnusankar
requested changes
Jul 1, 2023
docs/yarn.lock
Outdated
There was a problem hiding this comment.
@trace2798 Remove this file in favour of root yarn.lock. Run install commands on root directory
iamvishnusankar
approved these changes
Jul 3, 2023
ariesclark
pushed a commit
to ariesclark/next-sitemap-x
that referenced
this pull request
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the website. Working on docs and example layout