Use context managers to manage cleanups

[hynek]

Makes us better Python citizens and allows to pass context managers like sqlalalchemy.Engine.connect directly as factories.

Only downside is that we can't detect the async-ness of factories anymore because an async context manager function is a sync function that returns an async object…

Is this what you had in mind @RonnyPfannschmidt?

[RonnyPfannschmidt]

At first glance,this Looks like it

[hynek]

thanks for the quick feedback!

[RonnyPfannschmidt]

Asyncness is still detectable, by the incoming function Type

Additionally normal Generators Are not awaitabe

[hynek]

Asyncness is still detectable, by the incoming function Type

How? The usual ways using iscoroutinefunction and issyncgenfunction both return False.

[hynek]

Also fun fact, I've run into problems immediately with this approach and had to add an enter option to registration: 396f6df 😅

[RonnyPfannschmidt]

It May be a good idea to separate factories and contexts on the registration level

[hynek]

That's not really the problem (so far). It's just that independently from how factories represented internally, a factory may return a context manager and the question is what to do with it.

Just return it? Means you have to write boilerplate like this for all of them:

def factory():
    with Engine.connect() as conn:
        yield conn

This was the previous behavior.

If you always enter them, you lose control over when they entered. My personal example where that did something I didn't want is my unit of work transaction manager.

---

It's really just a trade-off between convenience and surprise whether enter should be True or False by default.