Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update english term for "happening really soon now" #73

Closed
wants to merge 1 commit into from

Conversation

mperham
Copy link

@mperham mperham commented Sep 20, 2016

In English, "a while" indicates something that won't happen in the next few seconds. "right now" means something will happen in the next few seconds.
#19

In English, "a while" indicates something that won't happen in the next few seconds.  "right now" means something will happen in the next few seconds.
Copy link

@ryansch ryansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hustcc
Copy link
Owner

hustcc commented Sep 21, 2016

OK, thank you very much, but because of the TravisCI's error result, this PR will not be merged.

I will update it by doing below:

  1. build-in en locale
  2. locales/en.js, locales/en_short.js
  3. testcase of locale en.

hustcc pushed a commit that referenced this pull request Sep 21, 2016
@hustcc
Copy link
Owner

hustcc commented Sep 21, 2016

done~

@hustcc hustcc closed this Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants