Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression - Game: "Gensou Suikoden - Tsumugareshi Hyakunen no Toki" Shows Black Squares in Some Text on Any Build Beyond 1.16.6 #19116

Closed
5 tasks done
Kolrath opened this issue May 7, 2024 · 7 comments · Fixed by #19122
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@Kolrath
Copy link

Kolrath commented May 7, 2024

Game or games this happens in

NPJH50535: Suikoden: Woven Web of the Centuries

What area of the game

One of the text / font characters is a centered period similar to a dash. This seems to specifically be the one that ends up being a black square. The easiest point to see it is immediately at the start of the game when it opens up into a tutorial fight against some boars. Select to use a Skill on the main characters turn and the only skill they have is "Form - Resolve" where the issue is present.

So far, the only place this occured outside of that skills name was in a conversation with an NPC where it was at the end of a sentence. I didn't have any convenient way at the time to retest that conversation in software rendering to see if it was the exact same center circular dash character but I suspect it was because regular periods have displayed fine in countless prior conversations.

What happens

On build 1.16.6 and earlier (tested all builds back to 15) the circular dash shows correctly.
On the next available build of 1.17 and beyond the circular dash shows incorrectly as a black square.

PPSSPP build 1 17 - Black Squares
This is it displaying wrong in 1.17

What should happen

PPSSPP build 1 16 6 - No Black Squares
This is it displaying correctly in 1.16.6

TESTING PERFORMED
If you use Software Rending with any build from 1.17 and beyond the text will display correctly so the issue is only present when using hardware rendering and the regression occurred somewhere between builds 1.16.6 and 1.17.

I tested 1.17 with all available backends (OpenGL, Direct3d 9, Direct3d 11, Vulkan) and stepped through all the various graphics toggles, resolutions, and scaling options with each backend and in all cases the black squares are present so its not linked to any specific backend.

GE frame capture

No response

Platform

Windows

Mobile device model or graphics card (GPU)

NVIDIA GeForce RTX 4070 (Driver Version 552.22 - most recent)

PPSSPP version affected

v1.17 and up

Last working version

v1.16.6 and below

Graphics backend (3D API)

Other

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try changing graphics settings to determine if one causes the glitch (especially speed hacks or enhancements/replacements.)
  • Include logs or screenshots of issue.
@sum2012 sum2012 added the GE emulation Backend-independent GPU issues label May 7, 2024
@sum2012
Copy link
Collaborator

sum2012 commented May 7, 2024

@Kolrath Please create a GE frame capture to let dev fix the problem
https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

@Kolrath
Copy link
Author

Kolrath commented May 7, 2024

Dang it! I was trying to be thorough but thought I missed something. Thanks for pointing it out. Don't remember ever doing one of these in the past so I hope I did this right...

NPJH50535_0004.zip

@sum2012
Copy link
Collaborator

sum2012 commented May 8, 2024

@Kolrath Well done ,you do right, wait dev to fix it.

@LunaMoo
Copy link
Collaborator

LunaMoo commented May 8, 2024

It fails to set a texture due to wrong size of 512x2048, it works when it's set correctly to 512x512, no idea what would set such size if PSP textures can only be square and 512x512 max.

@sum2012
Copy link
Collaborator

sum2012 commented May 8, 2024

It is interested to know the reason that old version 2048 change to 512 and next version don't do that.
On hand build test
good
v1.16.6-372-gc3f881b7a
bad
v1.16.6-499-g8f75649b4

edit:compare https://github.com/hrydgard/ppsspp/compare/v1.16.6-372-gc3f881b7a..v1.16.6-499-g8f75649b4

@sum2012
Copy link
Collaborator

sum2012 commented May 9, 2024

@hrydgard
git bisect result 5373b8c in #18475

@hrydgard
Copy link
Owner

Yeah, there I put a restriction on texture size, but apparently it's possible to use larger textures, it's just that only the top-left 512x512 texels will be valid.

I'll fix this soon.

@hrydgard hrydgard added this to the v1.18.0 milestone May 10, 2024
hrydgard added a commit that referenced this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants