"unknown file format" for what appears to be a standard jpg file.

[ploum]

I stumbled across a particular jpg file which seems to not be recognized by Chafa.

$chafa lexamen_plat1-scaled.jpg
chafa: Failed to open 'lexamen_plat1-scaled.jpg': Unknown file format

$file lexamen_plat1-scaled.jpg
lexamen_plat1-scaled.jpg: JPEG image data, progressive, precision 8, 1665x2560, components 4

$apt-cache policy chafa
chafa:
Installé : 1.14.4-1

[hpjansson]

Looks like it's an Adobe CMYK-space JPEG. The decoding fails because libjpeg can't convert from CMYK to RGB. We need to add some code to do this conversion ourselves.

References:
https://github.com/pytorch/vision/pull/7741/files
https://gitlab.gnome.org/GNOME/gegl/-/blob/master/operations/external/jpg-load.c
https://bugzilla.mozilla.org/show_bug.cgi?id=674619

Also, the GEGL and Mozilla references indicate some (or all?) Adobe CMYK images are inverted. We may need to handle markers too - but since there are good references available, it's not a big task.

[hpjansson]

Always good to see you here, btw. Hope you're doing well!

[ploum]

Hey HP, yeah, still using chafa 100 times a day in offpunk ;-) But work on coding has been very slow due to my new book coming out. But I hope to make a release soon.

Always a pleasure to discuss with you ;-)

[ploum]

Wow, already fixed. That was fast!

[hpjansson]

I will read the book :-)