Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add semantic commit prefix to dependabot PRs #131

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Dec 14, 2022

Which problem is this PR solving?

Our dependabot PRs are failing CI checks because of the PR title validation check. Instead of getting the PR title validation check to ignore dependabot PRs, I thought it would be better to add the correct semantic prefix to dependabot PRs instead.

Short description of the changes

  • Adds semantic prefix maint to all dependabot commits / PRs

How to verify that this has the expected result

Unfortunately, it doesn't seem like we can validate dependabot config changes without merging them in according to this issue.

I think this should work as expected based on:

@pkanal pkanal self-assigned this Dec 14, 2022
@pkanal pkanal added no-changelog Omit this PR from changelog/release notes. version: no bump A PR with maintenance or doc changes that aren't included in a release. type: maintenance The necessary chores to keep the dust off. type: bug Something isn't working and removed type: maintenance The necessary chores to keep the dust off. labels Dec 14, 2022
@pkanal pkanal marked this pull request as ready for review December 14, 2022 19:14
@pkanal pkanal requested a review from a team December 14, 2022 19:14
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks great. Let's try it 👍🏻

@pkanal pkanal merged commit 71112b4 into main Dec 14, 2022
@pkanal pkanal deleted the purvi/dependabot-pr-title-prefix branch December 14, 2022 19:30
pkanal added a commit that referenced this pull request Dec 14, 2022
## Which problem is this PR solving?
In #131, there was a config error which this PR fixes.

## Short description of the changes
- `include_scope: true` --> `include: "scope"`

## How to verify that this has the expected result
The [docs reference the more up to date config
](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message)option
for including scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Omit this PR from changelog/release notes. type: bug Something isn't working version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants