-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--port
option is missing from usage of the firewall {add,delete}-rule
commands
#733
Labels
Comments
--port
option is missing from usage of the firewall {add,delete}-rule
commands
I think this was missed because While testing this, I also found that we do not print the
|
This was referenced Apr 19, 2024
phm07
added a commit
that referenced
this issue
Apr 19, 2024
Switch cases don't fall through by default in Go, which lead to there being no user-friendly error emitted when the user attempts to create a TCP rule without specifying a port. Related to #733
phm07
added a commit
that referenced
this issue
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL;DR
The
--port
flag is missing from thehcloud firewall add-rule
andhcloud firewall delete-rule
commands.I don't know if this is expected, are only required flags part of the usage?
Expected behavior
That the
--port
flag is also part of the command usage.Observed behavior
Minimal working example
$ hcloud firewall add-rule --help
$ hcloud firewall delete-rule --help
Log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: