Restrict metrics layer installation to Node >=14.10 #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main functionality of this PR is to modify `nodejs-engine` so that the metrics script is only include when the Node.js version is 14.10 or higher + integration tests to verify that behavior. This PR also includes some refactoring around code related to obtaining the current Node.js version which is used by both `nodejs-engine` and `nodejs-npm-engine`. This is now available in `nodejs-utils` as `node::get_node_version`. Some common error handling output was also moved into `nodejs-utils`. [W-14838686](https://gus.lightning.force.com/lightning/r/a07EE00001iPnjsYAC/view)
…lity_cnb_changes * node_v14.10_compatiblility: Update CHANGELOG.md
joshwlewis
reviewed
Jan 23, 2024
| layer_name!("dist"), | ||
| DistLayer { | ||
| release: target_release.clone(), | ||
| }, | ||
| )?; | ||
|
|
||
| let env = dist_layer.env.apply(Scope::Build, &Env::from_current()); | ||
| let node_version = node::get_node_version(&env) |
There was a problem hiding this comment.
Don't we already know the Node.js version we installed (I think it's in the target_release object)? It seems like this might be an extra command we don't need.
|
Closing this PR. The suggestion you noted @joshwlewis is a better fit. The code to restrict the layer installation + the unit tests have been moved into #767. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked with PR - #767
The main functionality of this PR is to modify
nodejs-engineso that the metrics script is only include when the Node.js version is 14.10 or higher + integration tests to verify that behavior.This PR also includes some refactoring around code related to obtaining the current Node.js version which is used by both
nodejs-engineandnodejs-npm-engine. This is now available innodejs-utilsasnode::get_node_version.Some common error handling output was also moved into
nodejs-utils.W-14838686