[git] Force an empty git config upon git command executions within a repository #844
+51
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After having adopted some new global git configuration options I started seeing some failures in unit tests dealing with git operations. While the tests in question definitely deserve attention on their approach, letting our git actions consume the local ~/.gitconfig configuration file by default smells with non-determinism. This patch introduces a new wrapping helper class that forces a null config upon all git actions within a repository context. This is achieved via usage of environment variables for this purpose (there isn't a CLI option to do this). The change is sadly introduced as a conditional behaviour depending on particular version of git, because the new environment variables [1] were introduced in git 2.32.0 [2] (released in 2021) and while most supported platforms have already gone past the version, Debian 11 LTS is stuck at 2.30. [1] https://www.kernel.org/pub/software/scm/git/docs/git.html [2] https://raw.githubusercontent.com/git/git/master/Documentation/RelNotes/2.32.0.adoc Signed-off-by: Erik Skultety <[email protected]>
Adopt the new wrapping class introduced in previous commit. Signed-off-by: Erik Skultety <[email protected]>
|
If this approach is agreed upon then some of the existing |
|
Aand of course CI would require git config changes, sigh... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently adopted some new global git configuration which happened to break some of our unit tests. While the tests in question definitely deserve changes not to be so tightly coupled to an exact git output, we should also not let git pick up user configuration automatically if we want to keep consuming its output and process it further in our logic.
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)