Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --data-only to copy data without structure #140

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

reidab
Copy link
Contributor

@reidab reidab commented Aug 18, 2022

This was prompted as a workaround for the issue presented in #139.

By allowing data-only transfers to be run, we can use multiple config files in order to extract multiple subsets from the same table. An initial run, without --data-only, copies the DB structure and anonmized users while a second run using --data-only and a different config file copies unmodified versions of admin users to the same table.

It's likely useful in many other cases as well.

I'm happy to add some testing for this if necessary, but I'd appreciate some pointers on where best to add it. There doesn't seem to be any existing tests for the Dumper Engine or the steal command, where the bulk of this takes place.

This was prompted as a workaround for the issue presented in hellofresh#139.
By allowing data-only transfers to be run, we can use multiple config
files in order to extract multiple subsets from the same table. An
initial run, without `--data-only`, copies the DB structure and
anonmized users while a second run using `--data-only` and a different
config file copies unmodified versions of admin users to the same table.

It's likely useful in many other caeses as well.
Copy link
Contributor

@lucasmdrs lucasmdrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @reidab 👋

Thank you for your contribution ! 🎉

@lucasmdrs lucasmdrs merged commit 17d2104 into hellofresh:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants