Support dumping to AWS RDS Postgres servers #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 41.54% 41.54%
=======================================
Files 8 8
Lines 284 284
=======================================
Hits 118 118
Misses 159 159
Partials 7 7 Continue to review full report at Codecov.
|
vgarvardt
suggested changes
Sep 25, 2020
sjhewitt
force-pushed
the
sjh-rds-postgres
branch
from
0beb00f to
ad86442
Compare
|
👍
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AWS RDS Postgres servers the "superuser" does not have permission to run the
ALTER TABLE %s DISABLE TRIGGER ALLcommand. To get around this I've added a CLI argument--to-rdsthat indicates the dump is being done to an RDS database, and so will switch to looking up all the Foreign Keys in the database, and then usingALTER TABLE %s DROP CONSTRAINT %s/ALTER TABLE %s ADD CONSTRAINT %s %sto enable and disable the constraints.