Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT-6909 Fixed writing to the closed channel #115

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

vgarvardt
Copy link
Contributor

While engine dumper handles several tables dumping correctly query dumper was missing sync part so the first finished table was finishing the whole process.

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #115 into master will decrease coverage by 0.82%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   43.54%   42.72%   -0.83%     
==========================================
  Files           8        8              
  Lines         310      316       +6     
==========================================
  Hits          135      135              
- Misses        168      174       +6     
  Partials        7        7
Impacted Files Coverage Δ
pkg/dumper/query/dumper.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f12e9d...052daa7. Read the comment docs.

@boekkooi-fresh
Copy link
Contributor

boekkooi-fresh commented Apr 3, 2020

👍

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

@vgarvardt vgarvardt merged commit b572200 into master Apr 3, 2020
@vgarvardt vgarvardt deleted the hotfix/race-condition branch April 3, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants