PT-6909 Handle invalid anonymiser #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 43.18% 43.54% +0.36%
==========================================
Files 8 8
Lines 308 310 +2
==========================================
+ Hits 133 135 +2
Misses 168 168
Partials 7 7
Continue to review full report at Codecov.
|
vgarvardt
force-pushed
the
hotfix/invalid-anonymiser
branch
from
1900937 to
8ede86b
Compare
Co-Authored-By: Warnar Boekkooi <[email protected]>
Co-Authored-By: Warnar Boekkooi <[email protected]>
Co-Authored-By: Warnar Boekkooi <[email protected]>
|
+1
|
|
👍 I would have preferred less
|
|
@boekkooi-fresh I will squash PR into single commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently invalid anonymiser is just ignored. With this fix it will be reported to the log as error and to the dump to make it broken and attract attention.