Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT-6909 Extracted spec loading to config and added some tests #111

Merged
merged 4 commits into from
Apr 2, 2020

Conversation

vgarvardt
Copy link
Contributor

First piece extracted from bigger brother #110

In this PR:

  • improved error reporting
  • moved config loading to config package and covered it with basic tests
  • fixed init command as generated toml file has invalid structure - go sruct embedding for some reasons works differently for writing toml and reading it

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #111 into master will increase coverage by 3.1%.
The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #111     +/-   ##
=========================================
+ Coverage   32.09%   35.19%   +3.1%     
=========================================
  Files           5        6      +1     
  Lines         215      233     +18     
=========================================
+ Hits           69       82     +13     
- Misses        142      145      +3     
- Partials        4        6      +2
Impacted Files Coverage Δ
pkg/dumper/query/dumper.go 0% <0%> (ø) ⬆️
pkg/anonymiser/anonymiser.go 69.76% <100%> (ø) ⬆️
pkg/config/config.go 72.22% <68.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a750a29...0216803. Read the comment docs.

@boekkooi-fresh
Copy link
Contributor

boekkooi-fresh commented Apr 2, 2020

👍 LGTM

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

@vgarvardt vgarvardt merged commit f81f7a5 into master Apr 2, 2020
@vgarvardt vgarvardt deleted the hotfix/init-config-read branch April 2, 2020 15:22
@samacoff
Copy link

samacoff commented Apr 2, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants