More obvious way of returning dumper init erorrs

hellofresh · Apr 2, 2020 · 0216803 · 0216803
1 parent 527b44c
commit 0216803
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/dumper/dumper.go b/pkg/dumper/dumper.go
@@ -56,11 +56,13 @@ func NewDumper(opts ConnOpts, rdr reader.Reader) (dumper Dumper, err error) {
 		return false
 	})
 
-	if dumper == nil && err == nil {
-		err = fmt.Errorf("no supported driver found for dumper DSN %q", opts.DSN)
+	if err != nil {
+		return nil, wErrors.Wrapf(err, "could not create dumper for DSN: %q", opts.DSN)
 	}
 
-	err = wErrors.Wrapf(err, "could not create dumper for DSN: %q", opts.DSN)
+	if dumper == nil {
+		return nil, fmt.Errorf("no supported driver found for dumper DSN %q", opts.DSN)
+	}
 
 	return
 }