-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply timeout to kubeclient and remove KubeTimeout #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configurable with environment variable KUBE_CLIENT_TIMEOUT_SECONDS
Most of them are fast and local, with the only potentially slow part being kubeClient operations
- Apply 60 seconds time limit to controller syncHandler - Retain 30 seconds time limit for waitfor resource
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 57.42% 57.09% -0.34%
==========================================
Files 35 35
Lines 2504 2487 -17
==========================================
- Hits 1438 1420 -18
- Misses 952 953 +1
Partials 114 114
Continue to review full report at Codecov.
|
vgarvardt
reviewed
Jan 22, 2021
vgarvardt
reviewed
Jan 22, 2021
2bf9bc6
to
b85d857
Compare
f5dc28a
to
68ee8a2
Compare
fd31a83
to
d621ae0
Compare
5e7ef06
to
4c4c873
Compare
boekkooi-fresh
approved these changes
Jan 26, 2021
This was referenced Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
KubeTimeout
KUBE_CLIENT_TIMEOUT
environment variable to configure thisSYNC_HANDLER_TIMEOUT
environment variableKubeTimeout
) when waiting for kube resources to appear