Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cassandra checks #96

Merged
merged 4 commits into from
May 17, 2023
Merged

Conversation

boguth
Copy link
Contributor

@boguth boguth commented May 15, 2023

Adding support for Cassandra checks.

@lucasmdrs Split the cassandra checks with your suggested updates from the previous pr

Copy link
Contributor

@lucasmdrs lucasmdrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @boguth 👋

Thank you for the contribution! Don't worry about the unrelated lint issue, I'll sort it out and merge your PR after that.

@boguth
Copy link
Contributor Author

boguth commented May 16, 2023

Ayyye glad to hear it's approved! I appreciate your time and reviews. Still working on the s3 bit. If it makes sense, you should see another PR in a couple days. Thanks @lucasmdrs!

@lucasmdrs lucasmdrs merged commit f37c630 into hellofresh:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants